Open
Conversation
m-slama
approved these changes
Jul 14, 2022
fredmota
reviewed
Jul 14, 2022
Collaborator
fredmota
left a comment
There was a problem hiding this comment.
I think args to be change to None, or {}.
fredmota
approved these changes
Jul 14, 2022
ca11f60 to
cbc5e18
Compare
Author
True, fixed. Thanks for review. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After review of changelogs for differences between version
5.10.1and5.11.1no changes influencing the source code found.Plus Python 3 fixes for
exportConfig,importConfigandmkfilter.Plus minor fix of bad API POST call to
/api/kubernetes_nodes