Enable MIMO on RX for iwn driver (for Centrino N wireless cards)#411
Merged
Conversation
Collaborator
|
does the rx rate really increase? |
seplarack
approved these changes
Nov 22, 2020
seplarack
left a comment
There was a problem hiding this comment.
I can confirm that this code allows MCS Index to go higher. I also see up to MCS Index: 15.
Contributor
Author
|
@GrimFrost Thanks for the confirm. @zxystd The code base of iwn driver have most of the MIMO rx code ready, it is already specify the right flags in the rxon for all rxchains. However it is not advertise it in the supported MCS rates. This change is to advertise all the supported MCS. The similar code path also exists in the iwm/iwx driver. For the real-world test, I can see up to 80mbps in the speed test, which is now on-par with iwm driver I believe. I have another pull request #404 would like take a look. |
zxystd
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable MIMO on the rx path for iwn driver.
This change allow up to MCS 23 rate (216M) on rx. I tested with 2x2:2 and can see MCS 15 rate (144M) on rx.
There is still issues with MIMO on the tx path need to be figure out. Tx rate is still up to MCS 7 rate (72M) and in the real world I only see up to MCS 4 rate (43M).