Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Enhancements #70

Closed
wants to merge 1 commit into from
Closed

Conversation

dendvz
Copy link
Contributor

@dendvz dendvz commented Aug 9, 2017

Is there any specific reason behind timebase steps 1-2-4-10?

  1. Timebase steps 1-2-5-10 are more traditional, have better distribution on log scale

  2. dsoWidget: enabled timebase update

  3. Added CMakeLists.txt.user to .gitignore

…n on logarithmic scale

2) Added CMakeLists.txt.user to .gitignore
3) dsoWidget: enabled timebase update
@OliverHaag
Copy link
Contributor

Yes, at least the DSO2090 only got a few record lengths and samplerates that you can choose from. That's why only 1-2-4-10 make sense. 5 would record as much as 10 but throw away half of it while 4 will record with a higher samplerate as far as I remember.

@dendvz
Copy link
Contributor Author

dendvz commented Aug 10, 2017

@OliverHaag We should probably propose two different GUI views (skins?):

  1. Device-centric, where acquisition params controlled by user are sample rate and record length. Would make sense to change number of major / minor ticks along X-axis in this mode and completely hide "timebase" spinbox from Horizontal dock.

  2. Classical, where Horizontal dock shows only "timebase" spinbox, while sample rate and record length are hidden and calculated by device controller internally. Moreover, the range for timebase spinbox should also be restricted by device capabilities, e.g. 1ns/div is absolutely useless if max device sample rate is 48MS/s - the entire screen is 10ns wide and we can show only 1 sample at trigger position.

BTW, I would also suggest to move "frequency base" spinbox to "Spectrum" dock.

@dendvz dendvz mentioned this pull request Aug 25, 2017
@dendvz dendvz mentioned this pull request Nov 28, 2017
@dendvz
Copy link
Contributor Author

dendvz commented Nov 28, 2017

Closing this one, useful items moved into #86

@dendvz dendvz closed this Nov 28, 2017
@dendvz dendvz deleted the gui_enhancements branch November 28, 2017 19:05
GCarneiroA pushed a commit to GCarneiroA/openhantek that referenced this pull request Oct 29, 2020
Signed-off-by: Martin <Ho-Ro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants