Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color config dialog change + minor bugfixes #64

Merged
merged 2 commits into from
Aug 1, 2017

Conversation

dendvz
Copy link
Contributor

@dendvz dendvz commented May 9, 2017

  1. Enable user to choose screen & print colors separately (option already supported by DsoSettingsView.color).

  2. Enabled "Export Images with Screen Colors" checkbox in "Files" dialog.

  3. Couple of minor enhancements: fixed width of icons panel in Settings, suppress printing spectrum magnitude if spectrum is not printed.

  4. Bugfixes:
    Eliminated compile time warnings:

...helper.h:111:2: warning: extra ‘;’ [-Wpedantic]
 };
  ^
...control.cpp: In member function ‘unsigned int Hantek::Control::updateSamplerate(unsigned int, bool)’:
...control.cpp:724:26: warning: overflow in implicit constant conversion [-Woverflow]
         downsamplerValue = 0xffff;
                          ^

files_dialog_screenshot

new_color_dialog_screenshot

2) eliminated warning ...helper.h:111:2: warning: extra ‘;’ [-Wpedantic]
3) eliminated warning ...control.cpp:724:26: warning: overflow in implicit constant conversion [-Woverflow]
4) min width for Config dialog Icons widget
2) print spectrum magnitude only if spectrum is enabled
@davidgraeff davidgraeff merged commit 6ed0a5a into OpenHantek:master Aug 1, 2017
@dendvz dendvz deleted the use_print_colors branch January 7, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants