chore(openhands): remove no-op values file keys#869
Open
jlav wants to merge 2 commits into
Open
Conversation
jlav
marked this pull request as ready for review
July 13, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An audit of the values files for no-op keys (keys nothing consumes, prompted by an earlier typo where a postgres setting everyone believed was applied actually wasn't) turned up a batch in the openhands chart tree. The values file doubles as documentation of the available config options, so keys that do nothing are misleading. This removes them:
vertexAIblock (superseded by the vertex wiring in openhands-secrets / litellm-env-secrets),crdCheck.location(the crd-check hook reads every other key in that block),integrations-hub.service.baseUrl,integrations-hub.database.existingSecret, andruntime-api.externalDatabase(the subchart has noexternalDatabasehandling; its external DB config is thedatabaseblock).nodeSelector/tolerations/affinity(the deployment never wires them; onlykvm.nodeSelector/kvm.tolerationsexist),kvm.resourceName(the device plugin hardcodes^kvm$; the comment claimed otherwise), the unused parts of thepostgresqlblock, theexternalDatabaseblock, and thehelm-release-prunerblock (not a dependency, referenced nowhere).minioandpostgresqlblocks read like subchart pass-through config, but neither chart declares any dependency, so only the handful of keys their own templates read are live (minio.enabled/external/svcaccts[0],postgresql.enabled). Everything else is removed and the comments now describe what the flags actually do.service.baseUrl(templates readopenhands.baseUrl),database.existingSecret(no secret-creating template exists),database.poolSize/maxOverflow(never emitted into env).vertexAIvalues. VERTEXAI_PROJECT/VERTEXAI_LOCATION already reach litellm through the openhands-secrets chart.Helm Chart Checklist
Additional Notes
I verified this is a pure no-op:
helm templateoutput is byte-identical to main, both with defaults and with automation, integrations-hub, plugin-directory, agent-canvas, and the runtime-api kvm plugin force-enabled. Consumers still setting any of the removed keys keep working; the keys were ignored before and remain ignored.The one judgement call: I removed dead keys rather than wiring them up. If we actually want runtime-api pod-level
nodeSelector/tolerations/affinitysupport, that should be a deliberate feature change, and I'd rather not sneak it into a cleanup.