Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on deprecated #862

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Error on deprecated #862

merged 9 commits into from
Mar 27, 2024

Conversation

peter-lawrey
Copy link
Member

No description provided.

@peter-lawrey peter-lawrey requested a review from tgd March 22, 2024 18:32
Copy link

sonarcloud bot commented Mar 22, 2024

Copy link
Contributor

@tgd tgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Peter looking good - I added a few comments highlighting potential changes

pom.xml Show resolved Hide resolved
@peter-lawrey peter-lawrey changed the base branch from develop to x.26 March 25, 2024 13:25
@peter-lawrey peter-lawrey requested a review from tgd March 26, 2024 14:50
@peter-lawrey peter-lawrey merged commit bda1d72 into x.26 Mar 27, 2024
9 checks passed
@peter-lawrey peter-lawrey deleted the error-on-deprecated branch March 27, 2024 11:04
yevgenp pushed a commit that referenced this pull request Mar 28, 2024
* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.
peter-lawrey added a commit that referenced this pull request Mar 28, 2024
* Initial branch of x.26

* Error on deprecated (#862)

* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.

* Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail
peter-lawrey added a commit that referenced this pull request Apr 10, 2024
* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.
peter-lawrey added a commit that referenced this pull request Apr 10, 2024
* Initial branch of x.26

* Error on deprecated (#862)

* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.

* Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail
peter-lawrey added a commit that referenced this pull request Apr 15, 2024
* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.
peter-lawrey added a commit that referenced this pull request Apr 15, 2024
* Initial branch of x.26

* Error on deprecated (#862)

* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.

* Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail
peter-lawrey added a commit that referenced this pull request Apr 29, 2024
* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.
peter-lawrey added a commit that referenced this pull request Apr 29, 2024
* Initial branch of x.26

* Error on deprecated (#862)

* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.

* Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail
peter-lawrey added a commit that referenced this pull request May 28, 2024
* Initial branch of x.26

* Error on deprecated (#862)

* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.

* Deprecate due x.26

* reduced compatibility

* Remove se.eris.notnull.instrument

* Wire to 2.26ea0

* X.26 common compile flags (#865)

* Initial branch of x.26

* Error on deprecated (#862)

* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use UnsafeText here

* Don't use UnsafeText here

* Use release 8 only for Java 11+

* MacOSX issue on modification date

* Clarify why the @deprecated is commented out.

* Clarify why the @deprecated is commented out.

* Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail

* Tidy up compiler setting and some warnings

* X.26 lint all (#868)

* Add -Xlint:all,-options as default compiler

* Add -Xlint:all,-options as default compiler

* Add -Xlint:all,-options as default compiler

* @SuppressWarnings({"rawtypes"}) -> @SuppressWarnings("rawtypes")

* Minor fixes

* Narrow the SuppressWarnings

* X.26 lint all (#869)

* Add -Xlint:all,-options as default compiler

* Add -Xlint:all,-options as default compiler

* Add -Xlint:all,-options as default compiler

* @SuppressWarnings({"rawtypes"}) -> @SuppressWarnings("rawtypes")

* Minor fixes

* Narrow the SuppressWarnings

* Add -Xlint:all,-options as default compiler

* Fix deprecated field

* Fix deprecated field

* Tidy up code base

* resolve merge issues

* resolve Javadoc issues

* Added fail on warning lint for Javadoc, and rawtypes fixes for Bytes (#872)

* serializable warning suppressed

* Fix Javadoc formatting

* Fix warnings following rebase with develop

* Add methods for clear() and emptyHistory() to reduce direct references to VanillaMessageHistory

* Fix warnings following rebase with develop

* removed unwanted cast

* updated test

* FIX deprecation issues in Java 17+

* revert change

* Fix newlines

* </p> tag in javadoc not allowed

* Don't try to serialize a thread (#893)

* Using reflection to unmonitor a reference results in errors in Java 17 Fixes OpenHFT/Chronicle-Core#656

* Fix warnings following rebase with develop

* Add methods for clear() and emptyHistory() to reduce direct references to VanillaMessageHistory

* Handle deprecated members

* parent poms -> x.26.0

* Where marked for removal, also mark for deprecation

---------

Co-authored-by: yevgen.pavlenko <yevgen.pavlenko@chronicle.software>
Co-authored-by: Rob Austin <rob.austin@boundedbuffer.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants