Adv/add jaccoco #1681
Draft
Adv/add jaccoco #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er sonar - sonar profile: pass ci.sonar to tests via surefire - AppenderFileHandleLeakTest: scale THREAD_COUNT/MESSAGES_PER_THREAD in sonar mode - wrap GC-sensitive tests with FlakyTestRunner and add preAfter flush - jacoco: exclude AppenderFileHandleLeakTest from agent when sonar active - license: exclude docs/antora/** from license checks
… and exclude Antora docs - Ran license:format to insert headers where missing - Kept existing excludes for docs/antora and resources - Ensures Java 11+ verify passes license check
- avoid using deprecated SecurityManager API on newer JDKs - ensure test suite skips cleanly rather than failing - remove generated JaCoCo report artifact (-n)
- new tests for ChronicleWriterMain, InternalRemovableRollFileCandidatesMain, and RollingResourcesCache - raise sonar JaCoCo thresholds to 78% line / 71% branch
- ChronicleQueue.deltaCheckpointInterval(): add deprecation Javadoc and remove TODO-style comment - ChronicleHistoryReaderMainTest: remove SecurityManager usage, delete unused fields, use assertNotNull - Adjust help/exit tests to override printHelpAndExit without relying on System.exit
…S1186 - Add explanatory comments for empty methods in stub queue - Keep behavior unchanged; tests still pass
- Writes a message then invokes CLI and asserts output contains it - Complements ChronicleWriterMain CLI coverage
…ec under -Psonar; tests: add weekly parsing/error coverage for RollingResourcesCache; tests: add Linux OPEN/CLOSED state coverage for InternalFileUtil
… no-op methods; remove commented-out debug lines in DeleteFileTest and TestDeleteQueueFile
…and binary search comparator; clarify ExcerptCommon no-ops and add assertions
…lines 0.49, branches 0.35) for -P sonar
…view (compat suite) to increase coverage on roll-cycle parsing and toLong conversions
…five target tests present and compatible (RollingResourcesCacheCompat, ChronicleRollingIssue, WriteReadText, StoreAppenderDoubleBuffer, StoreAppender, ReferenceCountedCache)
…8, branches 0.356)
…align CLI arg; minor parity updates in MessageReaderWriterTest, MethodReaderObjectReuseTest, QueueAppendAfterRollReplayedIssueTest
Fix indentation mismatch on license URL lines flagged by
com.mycila:license-maven-plugin. Aligns with license_header.txt and
license_header_def.xml (currentYear=2025). Verified offline with
[INFO] Scanning for projects...
[INFO]
[INFO] --------------------< net.openhft:chronicle-queue >---------------------
[INFO] Building OpenHFT/Chronicle Queue 5.27ea11-SNAPSHOT
[INFO] from pom.xml
[INFO] -------------------------------[ bundle ]-------------------------------
[INFO]
[INFO] --- license:4.1:check (default-cli) @ chronicle-queue ---
[WARNING] Parameter 'legacyConfigExcludes' (user property 'license.excludes') is deprecated: use {@link LicenseSet#excludes}
[WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is deprecated: use {@link LicenseSet#header}
[INFO] Checking licenses...
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/How_it_works.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/Channel-Pipe-Benchmarks.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/pom.xml.bak
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/MigratingToV4.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/FAQ.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/DISCLAIMER.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/managing_roll_files_directly.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/BigDataAndChronicleQueue.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/utilities.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/async_mode.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/timezone_rollover.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/pretoucher.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/replication.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/performance.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/docs/encryption.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/systemProperties.adoc
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/README.adoc
[WARNING] Unable to find a comment style definition for some files. You may want to add a custom mapping for the relevant file extensions.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.847 s
[INFO] Finished at: 2025-10-31T17:20:31Z
[INFO] ------------------------------------------------------------------------ (BUILD SUCCESS).
…stness - Update Javadoc examples in FileUtil and InternalFileUtil to use java.nio.file.Files.delete(...) instead of File.delete(), aligning with modern APIs and Sonar guidance. - Add explicit default branches to switch statements handling header types and scan results to future‑proof against new enum constants and satisfy code quality rules. Build: mvn -o -DskipTests package (ok).
Add a short comment to ExcerptAppender.normaliseEOFs() to satisfy java:S1186 and clarify its intended empty implementation.
…ReaderMainTest - Replace ThreadDeath approach with a SecurityManager that throws on System.exit to validate help/exit paths. - Skip on JDK >= 17 where SecurityManager is removed. This aligns with adv/code-review branch patterns and reduces flakiness.
…cases Add a suite of additional tests covering cycle→name and name→cycle round‑trips across DAILY/HOURLY/MINUTELY and WeeklyRollCycle. Use round‑trip assertions for weekly to align with current format semantics.
Adds **/*.adoc to license-maven-plugin <excludes> to suppress
unknown-extension warnings and avoid attempting headers on AsciiDoc.
Verified with [INFO] Scanning for projects...
[INFO]
[INFO] --------------------< net.openhft:chronicle-queue >---------------------
[INFO] Building OpenHFT/Chronicle Queue 5.27ea11-SNAPSHOT
[INFO] from pom.xml
[INFO] -------------------------------[ bundle ]-------------------------------
[INFO]
[INFO] --- license:4.1:check (default-cli) @ chronicle-queue ---
[WARNING] Parameter 'legacyConfigExcludes' (user property 'license.excludes') is deprecated: use {@link LicenseSet#excludes}
[WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is deprecated: use {@link LicenseSet#header}
[INFO] Checking licenses...
[WARNING] Unknown file extension: /home/peter/Build-All/Chronicle-Queue/pom.xml.bak
[WARNING] Unable to find a comment style definition for some files. You may want to add a custom mapping for the relevant file extensions.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.853 s
[INFO] Finished at: 2025-10-31T18:30:10Z
[INFO] ------------------------------------------------------------------------.
- DumpMainTest: ensure dumping a queue directory prints headers and message contents (aligns with demo PrintQueueMain/DumpMain usage). - PretouchUtilTest: cover fallback event handler creation in non-enterprise environments; ignore enterprise feature warning. - NoOpConditionTest: exercise no-op Condition methods.
…mat/check - Add QueueOffsetSpecTest (parse/apply/format/validate) - Ran license:format and license:check — no header changes required.
Remove lifecycle binding of sortpom-maven-plugin so POM sorting happens only when explicitly invoked (e.g., [INFO] Scanning for projects... [INFO] [INFO] --------------------< net.openhft:chronicle-queue >--------------------- [INFO] Building OpenHFT/Chronicle Queue 5.27ea11-SNAPSHOT [INFO] from pom.xml [INFO] -------------------------------[ bundle ]------------------------------- [INFO] [INFO] --- sortpom:3.0.1:sort (default-cli) @ chronicle-queue --- [INFO] Sorting file /home/peter/Build-All/Chronicle-Queue/pom.xml [INFO] Pom file is already sorted, exiting [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.700 s [INFO] Finished at: 2025-10-31T19:30:06Z [INFO] ------------------------------------------------------------------------).
…turn value Do not assert false on EventHandler.action(); exercise the call and only verify no exception so it passes on both OSS fallback and enterprise implementations.
Fix PretouchUtil OSS fallback to return a simple no-op Pretoucher instead of delegating back to ChronicleQueue#createPretoucher(), which caused infinite recursion and StackOverflowError in community builds. Covered by PretouchUtilTest and full verify.
…sive Calls ChronicleQueue#createPretoucher() and executes it, asserting no StackOverflowError. Tolerates enterprise-only warnings and handler semantics.
# Conflicts: # pom.xml # src/test/java/net/openhft/chronicle/queue/ChronicleHistoryReaderMainTest.java # src/test/java/net/openhft/chronicle/queue/ChronicleRollingIssueTest.java # src/test/java/net/openhft/chronicle/queue/impl/single/IndexTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.