Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed currentTimeMillis() where timestamps come out in micros when uniqueness is enforced. #646 #647

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Fixed currentTimeMillis() where timestamps come out in micros when uniqueness is enforced. #646 #647

merged 4 commits into from
Apr 12, 2024

Conversation

peter-lawrey
Copy link
Member

…

@JerryShea
Copy link
Contributor

sonarcloud coverage for this PR shows some conditions not covered. May (or may not) be worth considering

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@peter-lawrey peter-lawrey merged commit 98003cf into develop Apr 12, 2024
9 of 10 checks passed
@peter-lawrey peter-lawrey deleted the core/issues/646 branch April 12, 2024 08:22
peter-lawrey added a commit that referenced this pull request Apr 12, 2024
@peter-lawrey
Fixed currentTimeMillis() where timestamps come out in micros when un…
1c20a93 
…iqueness is enforced. #646 (#647)

* Bug in currentTimeMillis() where timestamps come out in micros when uniqueness is enforced. #646

* Check more timestamps and they are increasing #646

* Check more timestamps and they are increasing #646

* Added concurrency tests for millis/nanos #646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgd tgd tgd approved these changes

@RobAustin RobAustin RobAustin approved these changes

@JerryShea JerryShea JerryShea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peter-lawrey @JerryShea @tgd @RobAustin