Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JvmTest fails on MacOS X with Intel processor #451

Closed
pcoppinger opened this issue Sep 28, 2022 · 4 comments
Closed

JvmTest fails on MacOS X with Intel processor #451

pcoppinger opened this issue Sep 28, 2022 · 4 comments
Assignees

Comments

@pcoppinger
Copy link

Running the "test" target generates the following error on my machine:

[ERROR] Tests run: 20, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 1.691 s <<< FAILURE! - in net.openhft.chronicle.core.JvmTest
[ERROR] net.openhft.chronicle.core.JvmTest.getCpuClass Time elapsed: 0.288 s <<< FAILURE!
org.junit.ComparisonFailure: Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz expected:<[Apple M1]> but was:<[Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz]>
at net.openhft.chronicle.core.JvmTest.getCpuClass(JvmTest.java:291)

Root cause is in Boorstrap.java, line 72:

static boolean isMacArm0() {
    return OS_NAME.equals("Mac OS X");
    // TODO FIX && CpuClass.CPU_MODEL.startsWith("Apple M");
}

I have noticed that because isMacArm0() erroneously returns true on my machine, there are several errors that also occur in Chronicle-Bytes. I will report these errors seperately.

@JerryShea
Copy link
Contributor

@pcoppinger can you advise what values the various constants in Bootstrap including CpuClass#CPU_MODEL have on your machine? If you configure your logger with net.openhft.chronicle.core.Bootstrap=DEBUG do you see any debug messages?

Feel free to submit a PR if you can make it work on your machine

@alamar
Copy link
Contributor

alamar commented Oct 31, 2022

@JerryShea os.arch=x86_64

@JerryShea
Copy link
Contributor

@pcoppinger pls try #459

@hft-team-city
Copy link
Collaborator

Released in Chronicle-Core-2.24ea1, BOM-2.24ea8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants