don't use finaliser by default. Closes #536

OpenHFT · Jun 23, 2023 · 30a4359 · 30a4359
1 parent bbebb0f
commit 30a4359
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/net/openhft/chronicle/core/io/AbstractCloseable.java b/src/main/java/net/openhft/chronicle/core/io/AbstractCloseable.java
@@ -37,7 +37,7 @@ public abstract class AbstractCloseable implements ReferenceOwner, ManagedClosea
     /**
      * Flag indicating whether discard warning is disabled.
      */
-    protected static final boolean DISABLE_DISCARD_WARNING = Jvm.getBoolean("disable.discard.warning", false);
+    protected static final boolean DISABLE_DISCARD_WARNING = Jvm.getBoolean("disable.discard.warning", true);
     @SuppressWarnings("DeprecatedIsStillUsed")
     @Deprecated(/* remove in x.25 */)
     protected static final boolean STRICT_DISCARD_WARNING;

diff --git a/system.properties b/system.properties
@@ -18,7 +18,7 @@
 
 # Tracing if resources are closed/released correctly.
 jvm.resource.tracing=true
-disable.resource.warning=true
+disable.discard.warning=false
 check.thread.safety=true
 # for profiling
 jvm.safepoint.enabled=true

diff --git a/systemProperties.adoc b/systemProperties.adoc
@@ -12,7 +12,7 @@ and so are enabled if either `-Dflag` or `-Dflag=true` or `-Dflag=yes`
 | background.releaser | `true` | Turn off the BackgroundResourceReleaser thread to manage resource releasing in your own thread | _BG_RELEASER_ (boolean)
 | chronicle.announcer.disable | `false` | If enabled, disables the InternalAnnouncer | _DISABLE_ANNOUNCEMENT_ (boolean)
 | debug | `false` | Returns if the JVM is running in debug mode |_IS_DEBUG_ (boolean)
-| disable.discard.warning | `false` | Called from finalise() implementations. If 'true', message is displayed stating that resource cannot be closed, and IllegalStateException is thrown  | _DISABLE_DISCARD_WARNING_ (boolean)
+| disable.discard.warning | `true` | Called from finalise() implementations. If 'false', message is displayed stating that resource cannot be closed, and IllegalStateException is thrown  | _DISABLE_DISCARD_WARNING_ (boolean)
 | disable.perf.info | `false` | if enabled, returns NullExceptionHandler | disablePerfInfo (boolean)
 | disable.resource.warning | `false` | If enabled, returns that resource tracing is turned on | boolean
 | disable.thread.safety | `false` | If enabled, threadSafetyCheck throws IllegalStateException in AbstractReferenceCounted.java and message thrown stating which component is not thread safe | _DISABLE_THREAD_SAFETY_ (boolean)