Fix spaghettiness #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Still need hosting? |
Possibly, was using DigitalOcean previously but if you have a better option I'm all ears! |
|
In that case, I suggest checking out Amazon Lightsail. Starting at $3.5/month for the lowest tier. Free 3 months trial. You can always go serverless for free! Shout out https://vercel.com |
|
|
Tried to close comment box and closed PR, classy. |
Parliament schedules for testing:ACT31-8-21 QLD13-8-21 31-8-21 Vic17-8-21 Tas24-8-21 SA13-8-21 24-8-21 WA17-8-21 NSW16-8-21 |
king-millez
force-pushed
the
not-spaghetti
branch
from
467828c to
69767ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anti spaghetti brigade
This pull request is similar to our ausbills update which refactors the code into a consistent model-based system.
Key changes
The main difference is the new
StreamModeldataclass, which creates a standard for stream objects that all sites must follow, e.g stream URLs, titles, and their live statuses.This method will make it easy for the web app to simply utilise
importlibto loop through the various parliaments, rather than the stupid system I wrote in late 2020 which is stupid and bad.The parliament modules have also all been moved into the
sitedirectory, so in the event that a jurisdiction secedes from Australia, or New Zealand becomes an Australian state, Legistream can quickly and automatically adapt to the minor changes.Closes Issues