Skip to content

[WIP] fixing cli test for protocol refactor#1788

Merged
IAlibay merged 10 commits intomulti-unit-rfefrom
multi-unit-rfe-fix-tests
Jan 15, 2026
Merged

[WIP] fixing cli test for protocol refactor#1788
IAlibay merged 10 commits intomulti-unit-rfefrom
multi-unit-rfe-fix-tests

Conversation

@atravitz
Copy link
Contributor

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@github-actions
Copy link

No API break detected ✅

@atravitz atravitz changed the base branch from main to multiunit-rfe January 12, 2026 23:18
@atravitz atravitz changed the base branch from multiunit-rfe to multi-unit-rfe January 12, 2026 23:19
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (multi-unit-rfe@0b060be). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             multi-unit-rfe    #1788   +/-   ##
=================================================
  Coverage                  ?   93.13%           
=================================================
  Files                     ?      194           
  Lines                     ?    17072           
  Branches                  ?        0           
=================================================
  Hits                      ?    15900           
  Misses                    ?     1172           
  Partials                  ?        0           
Flag Coverage Δ
fast-tests 93.13% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay marked this pull request as ready for review January 15, 2026 19:05
@IAlibay IAlibay merged commit 607d752 into multi-unit-rfe Jan 15, 2026
8 of 10 checks passed
@IAlibay IAlibay deleted the multi-unit-rfe-fix-tests branch January 15, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants