Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
- Coverage 99.05% 98.76% -0.29%
==========================================
Files 40 40
Lines 2430 2510 +80
==========================================
+ Hits 2407 2479 +72
- Misses 23 31 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b8bcb1e to
85ed3d1
Compare
|
opinions on |
IAlibay
left a comment
There was a problem hiding this comment.
I like the spirit / implementation of this approach.
The only thing I would bikeshed on is the name of the method, but purely on a "we might need to unify with draw at some point into a single keyword" - although as I say, not a hill I am that invested in.
I prefer D but only very mildly - I'd go with what you prefer, as long as we're consistent. |
| ) | ||
| ) | ||
|
|
||
| @requires_package("py3Dmol") |
There was a problem hiding this comment.
I think that using this decorator will actually only raise an issue with py3Dmol missing when you actually use the function.
| tests: | ||
| runs-on: ${{ matrix.OS }} | ||
| name: "💻-${{matrix.os }} 🐍-${{ matrix.python-version }} 🗃️${{ matrix.pydantic-version }}" | ||
| name: "💻-${{matrix.os }} 🐍-${{ matrix.python-version }} 🎨-${{ matrix.py3Dmol }}" |
There was a problem hiding this comment.
good idea! we will need to update the branch rules after we merge this PR in. I am happy with it for now, but it might be better to call it something like "min deps" so we can keep adding things to the install step. We can wait until the next optional dep we add to do this.
resolves OpenFreeEnergy/openfe#1498
copied over from openfe and named
LigandAtomMapping.view_3d()the plan is to deprecate
openfe.utils.visualization_3d.view_mapping_3dTips
Since this will create a commit, it is best to make this comment when you are finished with your work.
Checklist
newsentryDevelopers certificate of origin