Skip to content

Conversation

@jthorton
Copy link
Collaborator

Porting some of the fixes from OpenFreeEnergy/openfe#1566 to make sure HTF tests still pass till we can migrate the tests.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.87%. Comparing base (639b258) to head (fb7f72a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   86.86%   86.87%           
=======================================
  Files          11       11           
  Lines        1439     1440    +1     
=======================================
+ Hits         1250     1251    +1     
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.87%. Comparing base (639b258) to head (fb7f72a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   86.86%   86.87%           
=======================================
  Files          11       11           
  Lines        1439     1440    +1     
=======================================
+ Hits         1250     1251    +1     
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay requested a review from ijpulidos October 14, 2025 14:49
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IAlibay
Copy link
Member

IAlibay commented Oct 14, 2025

GPU runners aren't working, but I've tested most of the GPU tests locally and they seem to be passing.

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. LGTM!

@ijpulidos ijpulidos merged commit 73f74e1 into main Oct 17, 2025
7 checks passed
@ijpulidos ijpulidos deleted the htf_speed branch October 17, 2025 14:56
ijpulidos pushed a commit that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants