Avoided url appending with slash when matrix parameter exists #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Can anyone please check it ? |
velo
previously requested changes
Jul 8, 2019
Member
velo
left a comment
velo
left a comment
There was a problem hiding this comment.
Could you also include a unit test? To prevent from breaking again in the future?
Member
|
I’m just back from vacation. I will review this later today also. |
Contributor
Author
I have added UT as well now. |
kdavisk6
dismissed
velo’s stale review
I've reviewed and verified that there is a unit test.
kdavisk6
added
the
ready to merge
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Avoided url appending with slash when matrix parameter exists * Added UT to cover url appending with slash when matrix parameter exists
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Avoided url appending with slash when matrix parameter exists * Added UT to cover url appending with slash when matrix parameter exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue of passing matrix parameter using RequestTemplate
More details at #998