Fixes NullPointerException when accessing a FeignException's content #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the content of a FeignException is null, `contentUTF8()` now returns `null` rather than throwing a NullPointerException. `null` is chosen to allow possible future releases to return an empty optional rather than a blank String. Fixes #912
…achmann/feign into gh-912-npe-in-feignexception # Conflicts: # core/src/test/java/feign/FeignTest.java
Contributor
Author
|
@kdavisk6 I managed to implement a fix for the NPE and added a test for it. I hope I did everything correctly and am looking forward to your feedback. |
kdavisk6
reviewed
Mar 1, 2019
Member
kdavisk6
left a comment
kdavisk6
left a comment
There was a problem hiding this comment.
This looks pretty, good, but I wanted to get your thoughts on returning an empty string instead of null from contentUTF8. We don't explicitly state what the contract is here, but I think we should consider return a String, even an empty one, from this method all the time. What do you think?
kdavisk6
added
waiting for feedback
Contributor
Author
|
@kdavisk6 I've just implemented the change to return an empty String rather than null. |
kdavisk6
approved these changes
Mar 8, 2019
kdavisk6
removed
the
waiting for feedback
Member
|
@robachmann Thank you for updating the PR and congrats on your first contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the content of a FeignException is null,
contentUTF8()now returnsnullrather than throwing a NullPointerException.nullis chosen to allow possible future releases to return an empty optional rather than a blank String. Fixes #912