Add. hint message for missing Annotation Param's value#2874
Merged
velo merged 3 commits intoOpenFeign:masterfrom Jun 15, 2025
Merged
Add. hint message for missing Annotation Param's value#2874velo merged 3 commits intoOpenFeign:masterfrom
velo merged 3 commits intoOpenFeign:masterfrom
Conversation
rojae
changed the title
- Added a helpful hint in the exception message when @param is missing a value and parameter name can't be resolved. - Added a unit test to cover this case. - The test is skipped if the code was compiled with the `-parameters` compiler flag. Files affected: - Contract.java - DefaultContractTest.java Fixes OpenFeign#2337
auto-merge was automatically disabled
May 7, 2025 18:25
Head branch was pushed to by a user without write access
rojae
force-pushed
the
fix/2337-improve-param-exception-msg-add-hint
branch
from
087c942 to
cefb8c4
Compare
Contributor
Author
|
Hi @velo Since the parent POM uses the [Parent POM snippet] <compilerArgs>
<arg>-parameters</arg>
</compilerArgs>I've updated the test to skip execution when this flag is present, which should resolve the build failure. I missed this earlier because I only ran tests in the core module locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files affected:
Fixes #2337