fix: Response.protocolVersion may cause NPE #2351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etff
changed the title
etff
changed the title
velo
approved these changes
Mar 16, 2024
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix: set Response.protocolVersion default value * refactor: add default protocol version field * refactor: change to default protocol version value using builder field.
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* fix: set Response.protocolVersion default value * refactor: add default protocol version field * refactor: change to default protocol version value using builder field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found and fixed an issue where
Response.protocolVersionmay have caused NullPointerExceptions. #2314I believe
Response builderalready defaults toProtocolVersion.HTTP_1_1and using it when the
protocolVersionargument is null.I have other ideas:
UNKNOWNbased onLogger.javaand use it whenprotocolVersionargument is null.Responseis used.If you encounter any difficulties with this change, I'd appreciate some guidance or direction.