Skip to content

Conversation

@fbus
Copy link
Contributor

@fbus fbus commented Nov 27, 2023

When there is a gzip 'Content-Encoding' header, feign should create a GzipCompressingEntity to wrap the StringEntity / ByteArrayEntity.

This is a fix for this issue: #2245

@fbus
Copy link
Contributor Author

fbus commented Nov 27, 2023

I tried to follow the coding style.
I'm really not sure why there's so much code duplication between ApacheHttp5Client / AsyncApacheHttp5Client. They are very similar but AsyncApacheHttp5Client seems to be based on an older copy of ApacheHttp5Client.
I didn't try to solve this though, and just duplicated my fix

@velo velo merged commit 6f4226d into OpenFeign:master Dec 7, 2023
velo added a commit that referenced this pull request Oct 7, 2024
* Add support for request body gzip Content-Encoding

* do not use 'deflate' in unit test. It is not supported for requests

---------

Co-authored-by: Fabien Bussiron <fabien.bussiron@axa.fr>
Co-authored-by: Marvin <velo@users.noreply.github.com>
velo added a commit that referenced this pull request Oct 8, 2024
* Add support for request body gzip Content-Encoding

* do not use 'deflate' in unit test. It is not supported for requests

---------

Co-authored-by: Fabien Bussiron <fabien.bussiron@axa.fr>
Co-authored-by: Marvin <velo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants