Remove the unused code from the MethodInfo #1785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MethodInfo.configKey field is not more used since PR OpenFeign#1757 removing AsyncInvocation
kdavisk6
requested changes
Oct 9, 2022
Member
kdavisk6
left a comment
kdavisk6
left a comment
There was a problem hiding this comment.
configKey is required for use with HystrixFeign. This is not unused code.
Collaborator
Author
MethodInfo.configKey is not used. |
kdavisk6
approved these changes
Oct 10, 2022
kdavisk6
added
the
ready to merge
velo
added a commit
that referenced
this pull request
Oct 7, 2024
The MethodInfo.configKey field is not more used since PR #1757 removing AsyncInvocation Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
The MethodInfo.configKey field is not more used since PR #1757 removing AsyncInvocation Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MethodInfo.configKey field is not more used since PR #1757 removing AsyncInvocation