Changed RibbonClient to pass Feign Request.Options to LBClient #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NetflixOSS » feign » feign-pull-requests #47 SUCCESS |
Contributor
|
Looks good. Thanks! An editorial request below: Add an entry in CHANGES.md for 7.3 that says the following, and also reword your commit to say the same. "Adds Request.Options support to RibbonClient" When worded like this, the git log basically reads: Also, those wondering why they should update to Feign 7.3 will know what's new via CHANGES.md Looks nice, right? |
|
NetflixOSS » feign » feign-pull-requests #48 SUCCESS |
bstick12
force-pushed
the
ribbonclient
branch
from
f8215ae to
59a159e
Compare
|
NetflixOSS » feign » feign-pull-requests #49 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Feb 7, 2015
Changed RibbonClient to pass Feign Request.Options to LBClient
Contributor
|
fantastic. will cherry-pick into 7.x |
Contributor
Author
|
@adriancole Thanks very much. |
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Changed RibbonClient to pass Feign Request.Options to LBClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With suggested changes and from a different branch.
Could this be merged back to the next 7.x release?