-
Notifications
You must be signed in to change notification settings - Fork 2k
Extract asynchronous method handler #1756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
wplong11
wants to merge
3
commits into
OpenFeign:master
from
wplong11:3-extract-asynchronous-method-handler
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
176 changes: 176 additions & 0 deletions
176
core/src/main/java/feign/AsynchronousMethodHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,176 @@ | ||
| /* | ||
| * Copyright 2012-2022 The Feign Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package feign; | ||
|
|
||
| import feign.InvocationHandlerFactory.MethodHandler; | ||
| import feign.Request.Options; | ||
| import feign.codec.Decoder; | ||
| import feign.codec.ErrorDecoder; | ||
| import java.io.IOException; | ||
| import java.util.List; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.CompletionException; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.stream.Stream; | ||
| import static feign.ExceptionPropagationPolicy.UNWRAP; | ||
| import static feign.FeignException.errorExecuting; | ||
| import static feign.Util.checkNotNull; | ||
|
|
||
| final class AsynchronousMethodHandler implements MethodHandler { | ||
|
|
||
| private final MethodMetadata metadata; | ||
| private final Target<?> target; | ||
| private final Client client; | ||
| private final Retryer retryer; | ||
| private final List<RequestInterceptor> requestInterceptors; | ||
| private final ResponseInterceptor responseInterceptor; | ||
| private final Logger logger; | ||
| private final Logger.Level logLevel; | ||
| private final RequestTemplate.Factory buildTemplateFromArgs; | ||
| private final Options options; | ||
| private final ExceptionPropagationPolicy propagationPolicy; | ||
| private final Decoder decoder; | ||
|
|
||
|
|
||
| private AsynchronousMethodHandler(Target<?> target, Client client, Retryer retryer, | ||
| List<RequestInterceptor> requestInterceptors, ResponseInterceptor responseInterceptor, | ||
| Logger logger, Logger.Level logLevel, MethodMetadata metadata, | ||
| RequestTemplate.Factory buildTemplateFromArgs, Options options, | ||
| Decoder decoder, ExceptionPropagationPolicy propagationPolicy) { | ||
|
|
||
| this.target = checkNotNull(target, "target"); | ||
| this.client = checkNotNull(client, "client for %s", target); | ||
| this.retryer = checkNotNull(retryer, "retryer for %s", target); | ||
| this.requestInterceptors = | ||
| checkNotNull(requestInterceptors, "requestInterceptors for %s", target); | ||
| this.logger = checkNotNull(logger, "logger for %s", target); | ||
| this.logLevel = checkNotNull(logLevel, "logLevel for %s", target); | ||
| this.metadata = checkNotNull(metadata, "metadata for %s", target); | ||
| this.buildTemplateFromArgs = checkNotNull(buildTemplateFromArgs, "metadata for %s", target); | ||
| this.options = checkNotNull(options, "options for %s", target); | ||
| this.propagationPolicy = propagationPolicy; | ||
| this.responseInterceptor = responseInterceptor; | ||
| this.decoder = decoder; | ||
| } | ||
|
|
||
| @Override | ||
| public Object invoke(Object[] argv) throws Throwable { | ||
| RequestTemplate template = buildTemplateFromArgs.create(argv); | ||
| Options options = findOptions(argv); | ||
| Retryer retryer = this.retryer.clone(); | ||
| while (true) { | ||
| try { | ||
| return executeAndDecode(template, options); | ||
| } catch (RetryableException e) { | ||
| try { | ||
| retryer.continueOrPropagate(e); | ||
| } catch (RetryableException th) { | ||
| Throwable cause = th.getCause(); | ||
| if (propagationPolicy == UNWRAP && cause != null) { | ||
| throw cause; | ||
| } else { | ||
| throw th; | ||
| } | ||
| } | ||
| if (logLevel != Logger.Level.NONE) { | ||
| logger.logRetry(metadata.configKey(), logLevel); | ||
| } | ||
| continue; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| Object executeAndDecode(RequestTemplate template, Options options) throws Throwable { | ||
| Request request = targetRequest(template); | ||
|
|
||
| if (logLevel != Logger.Level.NONE) { | ||
| logger.logRequest(metadata.configKey(), logLevel, request); | ||
| } | ||
|
|
||
| Response response; | ||
| long start = System.nanoTime(); | ||
| try { | ||
| response = client.execute(request, options); | ||
| // ensure the request is set. TODO: remove in Feign 12 | ||
| response = response.toBuilder() | ||
| .request(request) | ||
| .requestTemplate(template) | ||
| .build(); | ||
| } catch (IOException e) { | ||
| if (logLevel != Logger.Level.NONE) { | ||
| logger.logIOException(metadata.configKey(), logLevel, e, elapsedTime(start)); | ||
| } | ||
| throw errorExecuting(request, e); | ||
| } | ||
| return responseInterceptor | ||
| .aroundDecode(new InvocationContext(decoder, metadata.returnType(), response)); | ||
| } | ||
|
|
||
| private long elapsedTime(long start) { | ||
| return TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - start); | ||
| } | ||
|
|
||
| private Request targetRequest(RequestTemplate template) { | ||
| for (RequestInterceptor interceptor : requestInterceptors) { | ||
| interceptor.apply(template); | ||
| } | ||
| return target.apply(template); | ||
| } | ||
|
|
||
| private Options findOptions(Object[] argv) { | ||
| if (argv == null || argv.length == 0) { | ||
| return this.options; | ||
| } | ||
| return Stream.of(argv) | ||
| .filter(Options.class::isInstance) | ||
| .map(Options.class::cast) | ||
| .findFirst() | ||
| .orElse(this.options); | ||
| } | ||
|
|
||
| static class Factory implements MethodHandler.Factory { | ||
|
|
||
| private final Client client; | ||
| private final Retryer retryer; | ||
| private final List<RequestInterceptor> requestInterceptors; | ||
| private final ResponseInterceptor responseInterceptor; | ||
| private final Logger logger; | ||
| private final Logger.Level logLevel; | ||
| private final ExceptionPropagationPolicy propagationPolicy; | ||
|
|
||
| Factory(Client client, Retryer retryer, List<RequestInterceptor> requestInterceptors, | ||
| ResponseInterceptor responseInterceptor, | ||
| Logger logger, Logger.Level logLevel, | ||
| ExceptionPropagationPolicy propagationPolicy) { | ||
| this.client = checkNotNull(client, "client"); | ||
| this.retryer = checkNotNull(retryer, "retryer"); | ||
| this.requestInterceptors = checkNotNull(requestInterceptors, "requestInterceptors"); | ||
| this.responseInterceptor = responseInterceptor; | ||
| this.logger = checkNotNull(logger, "logger"); | ||
| this.logLevel = checkNotNull(logLevel, "logLevel"); | ||
| this.propagationPolicy = propagationPolicy; | ||
| } | ||
|
|
||
| public MethodHandler create(Target<?> target, | ||
| MethodMetadata md, | ||
| RequestTemplate.Factory buildTemplateFromArgs, | ||
| Options options, | ||
| Decoder decoder, | ||
| ErrorDecoder errorDecoder) { | ||
| return new AsynchronousMethodHandler(target, client, retryer, requestInterceptors, | ||
| responseInterceptor, logger, logLevel, md, buildTemplateFromArgs, options, decoder, | ||
| propagationPolicy); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR, The AsynchronousMethodHandler is just copy and paste of the SynchronousMethodHandler. Then refactored in the PR #1757