Skip to content

support setting request factory in Google http client #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
velo merged 3 commits into from
Oct 14, 2021
Merged

support setting request factory in Google http client #1509

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
544fe7b
Minor: set request factory in Google http client constructor
Sep 20, 2021
ddedd48
Merge branch 'master' into add_request_factory_in_google_client
velo Oct 14, 2021
9e61957
Merge branch 'master' into add_request_factory_in_google_client
velo Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions googlehttpclient/src/main/java/feign/googlehttpclient/GoogleHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2012-2020 The Feign Authors
* Copyright 2012-2021 The Feign Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
Expand Down Expand Up @@ -41,16 +41,18 @@
* "https://api.github.com");
*/
public class GoogleHttpClient implements Client {
private final HttpTransport transport;
private final HttpRequestFactory requestFactory;

public GoogleHttpClient() {
this(new NetHttpTransport());
}

public GoogleHttpClient(final HttpTransport transport) {
this.transport = transport;
this.requestFactory = transport.createRequestFactory();
this(transport.createRequestFactory());
}

public GoogleHttpClient(final HttpRequestFactory requestFactory) {
this.requestFactory = requestFactory;
}

@Override
Expand Down