SOAPEncoder: Add support to modify soap message manually #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small extension adds the possibility to manually set soap headers. An example is given in the javadoc.
Laess3r
changed the title
Member
|
Ok, I will take a look once build is fixed. |
Contributor
Author
|
Thanks @velo ! I fixed the build 😄 |
velo
approved these changes
Sep 17, 2021
Member
velo
left a comment
velo
left a comment
There was a problem hiding this comment.
Overall looks good.
I suggested one change, but not sure how helpful it would be, please lemme know.
Wondering why you had to change headers in so many classes....
Member
|
No need, no big deal
…On Fri, 17 Sep 2021, 19:21 Stefan Lässer, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In soap/src/main/java/feign/soap/SOAPEncoder.java
<#1503 (comment)>:
> @@ -124,6 +124,9 @@ public void encode(Object object, Type bodyType, RequestTemplate template) {
Boolean.toString(writeXmlDeclaration));
soapMessage.setProperty(SOAPMessage.CHARACTER_SET_ENCODING, charsetEncoding.displayName());
soapMessage.getSOAPBody().addDocument(document);
+
+ modifySOAPMessage(soapMessage);
Great idea! I like it.
Regarding the changed headers: I updated them using the maven plugin.
Maybe some of them were not required to be updated. Should I revert them?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1503 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBLDURWWNXUAH3G7ZWN4DUCLUATANCNFSM5EB35V3Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
velo
approved these changes
Sep 22, 2021
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Add support to modify soap message manually This small extension adds the possibility to manually set soap headers. An example is given in the javadoc. * Increment copyright year * Fix code formatting * Increment copyright year * Increment copyright year * Fix formatting * Improve implementation Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Add support to modify soap message manually This small extension adds the possibility to manually set soap headers. An example is given in the javadoc. * Increment copyright year * Fix code formatting * Increment copyright year * Increment copyright year * Fix formatting * Improve implementation Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small extension adds the possibility to manually set soap headers.
An example is given in the javadoc.