Skip to content

Fix exception thrown when using a custom error decoder with metrics #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
velo merged 3 commits into from
Jul 26, 2021
Merged

Fix exception thrown when using a custom error decoder with metrics #1468

velo merged 3 commits into from
Jul 26, 2021
+31 −27

Conversation

@DarkAtra
Copy link
Contributor

@DarkAtra DarkAtra commented Jul 26, 2021

Fixes #1466

velo
velo reviewed Jul 26, 2021
View reviewed changes
micrometer/src/main/java/feign/micrometer/MeteredInvocationHandleFactory.java
} catch (Exception e) {
throw e;
} catch (Throwable e) {
throw new Exception(e);
Copy link
Member

@velo velo Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw no reason to have this layer of try catches... removed

@velo velo merged commit 7861fbc into OpenFeign:master Jul 26, 2021
velo added a commit that referenced this pull request Oct 7, 2024
@DarkAtra @velo
Fix exception thrown when using a custom error decoder with metrics (#…
2025dc2 
…1468)

* #1466: fixed metered feign client throwing IllegalArgumentException when using custom ErrorDecoder

* #1466: add missing license header

* Fold MeteredFeignClientTest into AbstractMetricsTestBase

Co-authored-by: Marvin Froeder <marvin.froeder@dovetailstudios.com>
velo added a commit that referenced this pull request Oct 8, 2024
@DarkAtra @velo
Fix exception thrown when using a custom error decoder with metrics (#…
a867d41 
…1468)

* #1466: fixed metered feign client throwing IllegalArgumentException when using custom ErrorDecoder

* #1466: add missing license header

* Fold MeteredFeignClientTest into AbstractMetricsTestBase

Co-authored-by: Marvin Froeder <marvin.froeder@dovetailstudios.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@velo velo velo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception Metrics cause IllegalArgumentException when using custom ErrorDecoders

2 participants

@DarkAtra @velo