Fix bug for FeignException cannot get the correct charset (#1325) #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdavisk6
requested changes
Dec 29, 2020
Member
kdavisk6
left a comment
kdavisk6
left a comment
There was a problem hiding this comment.
@Linda-pan Please add a unit test for this use case.
Member
|
@Linda-pan Your latest changes are not formatted correctly, please fun |
Linda-pan
commented
Jan 18, 2021
Contributor
Author
Linda-pan
left a comment
Linda-pan
left a comment
There was a problem hiding this comment.
Fix bug for FeignException cannot get the correct charset and add some tests
kdavisk6
approved these changes
Mar 7, 2021
kdavisk6
added
ready to merge
This was referenced Mar 15, 2021
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
) * Fix bug for FeignException cannot get the correct charset (#1325) * Add test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Add more test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Format test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Fix bug for FeignException cannot get the correct charset (#1325) * Add test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Add more test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Format test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Add test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Add more test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Format test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Correcting License Headers for 2021 Co-authored-by: Kevin Davis <kdavisk6@gmail.com>
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
) * Fix bug for FeignException cannot get the correct charset (#1325) * Add test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Add more test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Format test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Fix bug for FeignException cannot get the correct charset (#1325) * Add test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Add more test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Format test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Add test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Add more test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Format test for (Fix bug for FeignException cannot get the correct charset) (#1325) * Correcting License Headers for 2021 Co-authored-by: Kevin Davis <kdavisk6@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug for FeignException cannot get the correct charset(#1325)