Support Google Http Client

[blakesmith]

Hi feign friends!

We've been running our own Feign Client in production for the google-http-java-client (Repository is here: https://github.com/sproutsocial/feign-google-http-client). It's pretty small, and has been quite stable. Would there be any interest in this code being mainlined into the main feign repo as another feign submodule?

Thanks!

[kdavisk6]

@blakesmith

cc: @velo

This looks like a great addition. In order to bring this in, we will need to make the following changes:

1. Change the license to Apache 2.0
2. Change the package to feign.googleclient (or something similar)
3. Future changes will update the copyright to include both Sprout Social and OpenFeign.

If you are ok with these changes, I don't see any reason not to bring it in.

[blakesmith]

Totally fine with all of those changes. I'm happy to do the work to fold this in, and send PRs - please let me know the best way to go about this! :-)

Thank you for feign, and all the great work!

[kdavisk6]

The easiest is for you to create a fork, add your module as a new folder in the main repo and submit a PR with the module included in the parent and the appropriate versions set up. Let me know if you need any more help.

[blakesmith]

@kdavisk6 Sounds good. PR forthcoming.

[velo]

Agree with Kevin.
Send a PR our way and I would be happy to review it.

I kinda did already by looking at the original code and should be fine with the changes Kevin proposed.

I would also include a disclaimer on the original project pointing to be home.

[blakesmith]

PR is up here: #1057