Allow upto MaxStC outputs #2970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a boundary condition bug in ServoDyn's Structural Control (StC) output logic. The code was limiting outputs to 3 components instead of the intended maximum of 4 (MaxStC=4) due to using strict less-than comparison instead of less-than-or-equal-to.
- Changed condition from
(i < MaxStC)to(i <= MaxStC)in four StC output subroutines - Allows proper utilization of all 4 available StC output points per component
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
Back port to 4.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Structural Control currently limits outputs to a max of 4 points per component (
MaxStC=4). But the logic implemented in ServoDyn_IO limits it to three.This has been fixed by changing
(i < MaxStC)to(i <= MaxStC).Related issue, if one exists
None
Impacted areas of the software
ServoDyn/StC
Additional supporting information
Test results, if applicable