HD bug fix: prevent array index out-of-bound error in HDOut_MapOutputs when more than 9 potential-flow bodies are present #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when more than 9 potential-flow bodies are present
jjonkman
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Thanks for finding and fixing this bug!
FYI: This bug was originally reported in: https://forums.nrel.gov/t/hydrodyn-nbody-maximum-limit/7418.
andrew-platt
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
Currently, HydroDyn allows an arbitrary number of potential-flow bodies, but the relevant output channels are only available for the first 9 bodies. Having more than 9 bodies in HydroDyn will lead to a memory access exception during output.
This pull request fixes this bug. Output is still limited to the first 9 bodies, but having more potential-flow bodies in the model should no longer cause problems.
Impacted areas of the software
HydroDyn
Test results, if applicable
No change to existing tests since none involve more than 9 potential-flow bodies in HydroDyn.