AD: add new projection method and BEM methods #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated cmake tests with new location... as well as added the file to the Visual Studio project files.
Planning to remove this from EF, so I don't think there's a reason to keep it here.
Also use BEMMod_2D instead of hard-coded 0 in call to `getHubTipLossCorrection`
local `BEMT_Mod` is now `BEM_Mod`; also use `BEMMod_2D` parameter instead of hard-coded `0`
Minor updates for AD new projection branch.
bjonkman
reviewed
Oct 12, 2022
bjonkman
reviewed
Oct 12, 2022
|
Hi @bjonkman These outputs are indeed a bit confusing with the different coordinate systems. Thank you for this careful review! |
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged. It has been reviewed by @bjonkman.
Feature or improvement description
To help the development of new BEM algorithms, with different projection methods and implementations, some flags are introduced to the AeroDyn code. The flags are currently "hidden" to the user, as we need more time to decide on the implementation, document it, and add tests. In the long term, this version should have limited code differences with Envision's version.
Impacted areas of the software
AeroDyn
Additional supporting information
Two main toggles are introduced
o APM_BEM_NoSweepPitchTwist=1 "Original AeroDyn model where momentum balance is done in the WithoutSweepPitchTwist system"
o APM_BEM_Polar=2 "Use staggered polar grid for momentum balance in each annulus"
o APM_LiftingLine=3 "Use the blade lifting line (i.e. the structural) orientation (currently for OLAF with VAWT)"
o BEMMod_2D=0 "2D BEM assuming Cx, Cy, phi, L, D are in the same plane"
o BEMMod_3D=2 "3D BEM assuming a momentum balance system, and an airfoil system"
The BEM time integration now uses the standard "utimes" vector instead of indices 1 and 2 which were hardcoded.
The coordinate system "withoutSweepPitchTwist" is now renamed orientationAnnulus, and of type R8Ki.
Test results, if applicable
Test should match.
Checklist