-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft v2.0.0 - Error in new build system prevents correct schema generation #152
Comments
Running the scripts doesn't work for me (Windows 10). |
Okay, will adapt this to run on Windows. I run everything using Linux in WSL (on Windows). |
Another thing the "metaMetadata" field is not added to the example metadata. |
There is a duplication of the table name in the general keys and resource keys. resource/Name: A resource MUST contain a name unique to amongst all resources in this data package. To comply with the data package standard it must consist of only lowercase alphanumeric character plus ".", "-" and "_". It may not start with a number. In a database this will be the name of the table within its containing schema. It would be usual for the name to correspond to the file name (minus the file-extension) of the data file the resource describes. Example: resource/path: A URL that should be a permanent http(s) address or other path directly linking to the resource. |
…names Bugfix duplicate names in resources #152
The restriction of the table name when creating tables on the oep is slightly different. Only alphanumeric characters plus “_” are permitted. But since there is no field to save the schema name, this is fine. |
Yes, that is good and sustainable solution. It is somehow duplicate to the |
Subject IMO is also or maybe more duplicated with keywords. It is meant for ontological annotation for specific topics like "co2 emission"but more detailed than the data topics on the oep. But keywords are harmonized with OEP Tags ... |
… for resource objects as objects in a list #152
…ild system prevents correct schema generation #152
Description of the issue
The new build system to generate the full chain of: schema.json -> template.json / example.json is currently broken. There is an error that occurs during the schema resolve step. In this step the structure is read and the $refs are resolved. Based on the structure, the resources list element is generated. This element contains n objects. The jsonschema property is missing some properties:
type": "object",
properties": {
This leads to a malformed jsonschema.
Additionally, the group keys from the structure files are copied to the the generated schema.json. This is not expected as they are only used to better group the $ref elements. Thy should be replaced with the content form the reference file.
Steps to Reproduce
Ideas of solution
Fix the scripts to properly resolve the refs and replace the ref group field names in the resulting schema.json.
Workflow checklist
The text was updated successfully, but these errors were encountered: