Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Dashboard Components (Sidebar) #1316

Draft
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

hazeltonbw
Copy link
Contributor

@hazeltonbw hazeltonbw commented Jul 23, 2024

Description

In this PR the main focus was to streamline the admin panel to make it more user friendly.
This PR introduces a new sidebar that organizes each setting into their own category, making it easy for admins to find the settings they need to change.
This PR supersedes #1310 as it contained commits relating to editing users, which is not related to these changes.
Please leave any comments/suggestions. Thank you

Several comments/issues have been addressed that were brought up in PR #1310

  1. The items are not alphabetical as are menus in OED. (fixed)
  2. Users are being removed from this page. (Users component removed from admin dashboard)
  3. Might be nice to have an all option to see everything. (added)
  4. ESLint warning on missing param in JSDoc. (fixed)
  5. Translation file (data.ts) was reverted back to last known happy state with symbols and verified translations, and includes all of the necessary changes for this PR.

Partially Addresses: #890

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

These changes will require an update to this documentation page

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

@hazeltonbw hazeltonbw marked this pull request as draft August 1, 2024 08:37
@hazeltonbw hazeltonbw changed the title Admin Dashboard Components Admin Dashboard Components (Sidebar) Aug 1, 2024
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @hazeltonbw for the idea of adding a sidebar. A couple of comments:

  • Please try to keep this PR consistent with the new PR Admin components clean (without sidebar) #1324 so those changes are not lost.
  • Could the description be updated so it is clear this only desires to add the sidebar and is open for comment on the idea?

@huss
Copy link
Member

huss commented Aug 2, 2024

This proposes to add a sidebar to the admin settings page. I think it is an interesting idea but wanted to seek input from others:

  • Do you like it? Any suggestions?
  • It is done within the page and does not use a package. It has the advantage of being simple and not increasing the app payload. However, I want to see if others think we should consider a standard way to add this (including the next point)?
  • If this is going to be adopted, should it be added to any other places such as the meter create/edit modal. If going onto modal pages then we need to consider how it will look and space on the modal popup.
  • Anything else?

I appreciate any thoughts and your doing this.

(This mirrors a msg posted on our Discord channel.)

@hazeltonbw
Copy link
Contributor Author

Thanks to @hazeltonbw for the idea of adding a sidebar. A couple of comments:

This PR completely changes the layout of the admin settings page and therefore does not need most of the changes in PR #1324. However, changes to the translations and settings are kept consistent with that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants