feat: Implement NetworkRepository to interact with Mirror Node REST API #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added records for ExchangeRate, NetworkFee, NetworkStake and NetworkSupplies - Implemented method in MirroNodeClient to query exchangeRate, fees, stake and supplies - Added test for NetworkRepository Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Contributor
Author
|
Hi, @hendrikebbers, |
Member
|
@manishdait this is a really great addition. Thank you so much :) In CI, the tests are executed against a small networkub.com/OpenElements/hedera-solo-action. that is created by https://github.com/OpenElements/hedera-solo-action. Maybe it does not support the suplies functionality. Can you deactive the unit test for now and create an issue that the test should be fixed for CI in future. Once that is done I will merge your great work! |
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Contributor
Author
|
@hendrikebbers, I have disabled |
Member
|
Great. CI build is still broken but that belongs on an error done by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
NetworkRepositoryinterface and its implementation to interact with the Mirror Node REST API to query network related information.Closes: #38