Skip to content

#45 Add constructor tests for TopicDeleteRequest #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hendrikebbers merged 4 commits into from
Oct 22, 2024
Merged

#45 Add constructor tests for TopicDeleteRequest #54

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a972e54
Add constructor tests for TopicDeleteRequest
SaltedTan Oct 19, 2024
96dfc23
Fix wrong test cases
SaltedTan Oct 20, 2024
9105933
Remove empty line
SaltedTan Oct 20, 2024
9c14f9d
Merge branch 'main' into add-constructor-tests-TopicDeleteRequest
hendrikebbers Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion ...-base/src/test/java/com/openelements/hedera/base/test/ProtocolLayerDataCreationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import com.hedera.hashgraph.sdk.Hbar;
import com.hedera.hashgraph.sdk.PrivateKey;
import com.hedera.hashgraph.sdk.Status;
import com.hedera.hashgraph.sdk.TopicId;
import com.hedera.hashgraph.sdk.TransactionId;
import com.hedera.hashgraph.sdk.ContractFunctionResult;
import com.hedera.hashgraph.sdk.proto.ContractFunctionResultOrBuilder;
Expand Down Expand Up @@ -50,6 +51,7 @@
import com.openelements.hedera.base.protocol.FileDeleteRequest;
import com.openelements.hedera.base.protocol.FileCreateRequest;
import com.openelements.hedera.base.protocol.TopicSubmitMessageResult;
import com.openelements.hedera.base.protocol.TopicDeleteRequest;
import com.openelements.hedera.base.protocol.TopicCreateRequest;

import java.lang.reflect.Constructor;
Expand Down Expand Up @@ -743,7 +745,28 @@ void testTopicSubmitMessageResultCreation() {
}

@Test
void testTopicCreateResultCreation() {
void testTopicDeleteRequestCreation() {
//given
final Hbar maxTransactionFee = Hbar.fromTinybars(1000);
final Duration transactionValidDuration = Duration.ofSeconds(10);
final String topicIdString = "0.0.12345";
final TopicId topicId = TopicId.fromString(topicIdString);

//then
Assertions.assertDoesNotThrow(() -> TopicDeleteRequest.of(topicId));
Assertions.assertDoesNotThrow(() -> new TopicDeleteRequest(maxTransactionFee, transactionValidDuration, topicId));
Assertions.assertDoesNotThrow(() -> new TopicDeleteRequest(null, transactionValidDuration, topicId));
Assertions.assertDoesNotThrow(() -> new TopicDeleteRequest(maxTransactionFee, null, topicId));
Assertions.assertDoesNotThrow(() -> new TopicDeleteRequest(null, null, topicId));
Assertions.assertThrows(NullPointerException.class, () -> TopicDeleteRequest.of(null));
Assertions.assertThrows(NullPointerException.class, () -> new TopicDeleteRequest(maxTransactionFee, transactionValidDuration, null));
Assertions.assertThrows(NullPointerException.class, () -> new TopicDeleteRequest(null, transactionValidDuration, null));
Assertions.assertThrows(NullPointerException.class, () -> new TopicDeleteRequest(maxTransactionFee, null, null));
Assertions.assertThrows(NullPointerException.class, () -> new TopicDeleteRequest(null, null, null));
}

@Test
void testTopicCreateResultCreation() {
//given
final TransactionId validTransactionId = TransactionId.fromString("0.0.123451@1697590800.123456789");
final Status validStatus =Status.SUCCESS;
Expand Down