#46 Add constructor tests for TopicDeleteResult #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
| } | ||
|
|
||
| @Test | ||
| void testTopicDeleteResult() { |
Member
There was a problem hiding this comment.
@rdodiya looks good but change testTopicDeleteResult() method name to testTopicDeleteResultCreation() for consistence in the naming convetion.
|
|
||
| @Test | ||
| void testTopicDeleteResult() { | ||
|
|
Member
There was a problem hiding this comment.
Delete this empty line as well
…teResultCreation()
Contributor
Author
|
Hi @Ndacyayisenga-droid , I have updated the changes, please review it. |
Member
LGTM |
Ndacyayisenga-droid
approved these changes
Oct 18, 2024
hendrikebbers
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issue #46
Summary
Constructor tests for the TopicDeleteResult was added in the ProtocolLayerDataCreationTests class
A new test method i.e testTopicDeleteResult was added in the ProtocolLayerDataCreationTests class that implements all the needed tests for the TopicDeleteResult.