Add constructor tests for FileCreateRequest #29
Conversation
|
@Ariho-Seth I would suggest you always run tests locally before a PR |
|
Something wrong happened @Ndacyayisenga-droid ? |
|
Hello @Ndacyayisenga-droid , i think the PR is now good to go |
@Ariho-Seth LGTM |
|
@Ariho-Seth please you commited more files than you were supposed to |
|
There is a small issue that was raised, on removing un used imports in those particular files , so they are the ones i removed and commited |
|
@Ariho-Seth looks like you tried to use NPM / NODE in the project. Since this is a java project NPM and NODE are wrong. They are for JavaScript. |
|
Ohhh Yeah sure, I had some JS repo i was working with, i think somehow intermixed the commands |
| } | ||
|
|
||
|
|
||
|
|
| Assertions.assertDoesNotThrow(() -> new FileCreateRequest(maxTransactionFee, transactionValidDuration, contents, expirationTime, null)); | ||
| Assertions.assertDoesNotThrow(() -> new FileCreateRequest(maxTransactionFee, transactionValidDuration, contents, null, null)); | ||
| Assertions.assertThrows(IllegalArgumentException.class, () -> FileCreateRequest.of(largeContents)); | ||
| Assertions.assertThrows(NullPointerException.class, () -> FileCreateRequest.of(contents, null)); |
There was a problem hiding this comment.
Just change the above line to
Assertions.assertThrows(NullPointerException.class, () -> FileCreateRequest.of(null));
| import com.openelements.hedera.base.protocol.TokenAssociateRequest; | ||
| import com.openelements.hedera.base.protocol.FileUpdateRequest; | ||
| import com.openelements.hedera.base.protocol.FileInfoRequest; | ||
| import com.openelements.hedera.base.protocol.*; |
There was a problem hiding this comment.
@Ariho-Seth you should not use an asterisk wildcard(*). Its a bad practice
|
Thanks for working on this @Ariho-Seth |
hendrikebbers
added
the
hacktoberfest-accepted
3 participants
Summary
Constructor tests for the FileCreateRequest Record were added in the ProtocolLayerDataCreationTests class
A new test method i.e testFileCreateRequestCreation was added in the ProtocolLayerDataCreationTests class that implements all the needed tests for the FileCreateRequest record
Issue Link
#4
Issue Number
#4