Skip to content

Conversation

@iseeberg79
Copy link
Contributor

  • Correction for the smart-mode skip logic: Modbus writes are skipped if the power change is within the tolerance or unchanged, unless the watchdog interval is exceeded.
  • Implemented an idle zone: any power within tolerance (i.e. ±50 W per default) is set to 0 to reduce unnecessary battery cycling and inverter wear.

Co-Authored-By: deadrabbit87 <24924801+deadrabbit87@users.noreply.github.com>
@iseeberg79
Copy link
Contributor Author

@deadrabbit87 please double check and review
We should convert it from draft PR to PR after it has run for a while

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3417      +/-   ##
=============================================
+ Coverage      59.74%   59.75%   +0.01%     
  Complexity       112      112              
=============================================
  Files           2870     2870              
  Lines         124042   124043       +1     
  Branches        9298     9294       -4     
=============================================
+ Hits           74101    74113      +12     
+ Misses         47159    47151       -8     
+ Partials        2782     2779       -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iseeberg79 iseeberg79 marked this pull request as ready for review November 17, 2025 05:48
@deadrabbit87
Copy link
Contributor

Maybe you should run https://github.com/OpenEMS/openems/blob/develop/tools/prepare-commit.sh to prepare the PR for merging?

@iseeberg79
Copy link
Contributor Author

Not required for these changes I assume, changes actually nothing

Thanks, for reviewing ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants