Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some UI display error #2837

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Conversation

da-Kai
Copy link
Contributor

@da-Kai da-Kai commented Oct 13, 2024

Fix reserve soc bar

old new
pbar_old pbar_new

Fix live chart cutoff

old new
chart_old chart_new

Fix firefox css error

Bildschirmfoto vom 2024-10-12 14-24-54

@da-Kai da-Kai changed the title Feature/fix dispaly error Fix some UI display error Oct 13, 2024
@da-Kai da-Kai requested a review from lukasrgr October 13, 2024 09:39
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2837      +/-   ##
=============================================
+ Coverage      56.11%   56.11%   +0.01%     
  Complexity      8547     8547              
=============================================
  Files           2140     2140              
  Lines          90537    90538       +1     
  Branches        6717     6717              
=============================================
+ Hits           50797    50799       +2     
  Misses         37984    37984              
+ Partials        1756     1755       -1     

@sfeilmeier sfeilmeier merged commit 864d7ce into OpenEMS:develop Oct 13, 2024
6 of 7 checks passed
export class FlatWidgetPercentagebarComponent extends AbstractFlatWidgetLine { }
export class FlatWidgetPercentagebarComponent extends AbstractFlatWidgetLine {
protected get displayPercent(): number {
return Math.round(Number.parseFloat(this.displayValue));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could throw null pointer

@da-Kai da-Kai deleted the feature/fix-dispaly-error branch October 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants