Exposed some opensfm parameters #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakotabenjamin
approved these changes
May 16, 2018
opendm/config.py
Outdated
| type=int, | ||
| default=3, | ||
| help=('Minimum number of views that should reconstruct a point for it to be valid. Use lower values ' | ||
| 'if your images have few overlap. Lower values result in denser point clouds ' |
There was a problem hiding this comment.
I think the grammatically correct word here is less, this is the only nitpicky comment i can make because the rest of this looks great!
There was a problem hiding this comment.
We care about grammar, so I'll fix it.
smathermather
approved these changes
May 17, 2018
|
We should not forget to update the docs, either. |
|
Pull request opened in the docs. |
peddyhh
pushed a commit
to peddyhh/ODM
that referenced
this pull request
Jun 7, 2020
Exposed some opensfm parameters Former-commit-id: bde3989
pierotofy
added a commit
that referenced
this pull request
Sep 21, 2020
Exposed some opensfm parameters Former-commit-id: bde3989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of #769
I would merge after tomorrow's demo, just in case...