Conversation
added 4 commits
February 26, 2025 08:09
Do not depend on a global wildcard import, make sure tests import what they need. Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
We want to know the MSRV so CI can verify that the crate still builds with that rust version. Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Prior to enabling CI, let's make sure all clippy warnings are corrected. Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Let CI run Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
felipebalbi
requested review from
RobertZ2011,
akshat2112,
Copilot,
jeffglaum,
jerrysxie,
philgweber and
tullom
There was a problem hiding this comment.
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/rolling.yml:53
- The 'msrv' job in the rolling workflow uses '${{ matrix.commit }}' in the job name and subsequent checkout steps even though it is not defined in the matrix; consider adding it to the matrix or removing the reference.
name: ubuntu / ${{ matrix.msrv }} (${{ matrix.commit }})
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: true | ||
| ref: ${{ matrix.commit }} |
There was a problem hiding this comment.
The 'hack' job references '${{ matrix.commit }}' in its checkout step without defining a matrix; consider adding a commit variable to the matrix or replacing the reference with a valid commit identifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable CI for tmp108 driver.