Switch to device-driver crate#27
Merged
felipebalbi merged 19 commits intoOpenDevicePartnership:mainfrom Oct 30, 2025
Merged
Conversation
felipebalbi
force-pushed
the
switch-to-device-driver
branch
2 times, most recently
from
a259b2c to
3ef6e66
Compare
kurtjd
previously approved these changes
Oct 23, 2025
felipebalbi
force-pushed
the
switch-to-device-driver
branch
from
3ef6e66 to
af327a0
Compare
added 4 commits
October 23, 2025 15:07
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
felipebalbi
force-pushed
the
switch-to-device-driver
branch
from
af327a0 to
df0c2c6
Compare
added 8 commits
October 23, 2025 15:12
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
deny instead of forbid otherwise we can't ignore them for the auto-generated module. Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Contributor
Author
|
If anybody has any idea how to tell clippy to ignore the auto-generated module, let me know. |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the TMP108 driver to use the device-driver crate for code generation, replacing the previous manual register handling implementation. The change consolidates both blocking and async APIs into a single implementation using conditional compilation, and introduces a TOML-based register definition that auto-generates register access code.
Key changes:
- Replaced manual register definitions with auto-generated code from
tmp108.toml - Unified blocking and async implementations using
maybe-async-cfg - Updated MSRV from 1.84 to 1.85 to support Rust edition 2024
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tmp108.toml | New TOML file defining TMP108 register layout and fields for code generation |
| src/inner.rs | New auto-generated register access implementation from device-driver crate |
| src/lib.rs | Consolidated driver implementation supporting both blocking and async modes |
| src/registers.rs | Removed manual register definitions (replaced by auto-generated code) |
| src/blocking.rs | Removed separate blocking API (unified into lib.rs) |
| src/asynchronous.rs | Removed separate async API (unified into lib.rs) |
| Cargo.toml | Updated dependencies, MSRV, and edition to support new architecture |
| README.md | Updated MSRV documentation from 1.79 to 1.85 |
| .github/workflows/rolling.yml | Updated MSRV in CI configuration |
| .github/workflows/check.yml | Enhanced testing matrix and re-enabled semver checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
added 2 commits
October 24, 2025 08:37
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
felipebalbi
force-pushed
the
switch-to-device-driver
branch
from
390226b to
073dfeb
Compare
Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kurtjd
previously approved these changes
Oct 24, 2025
tullom
previously approved these changes
Oct 24, 2025
Signed-off-by: Felipe Balbi <felipe.balbi@microsoft.com>
felipebalbi
force-pushed
the
switch-to-device-driver
branch
from
ab83260 to
4de662c
Compare
kurtjd
previously approved these changes
Oct 29, 2025
Contributor
kurtjd
left a comment
kurtjd
left a comment
There was a problem hiding this comment.
Not sure why it's getting stuck on that ubuntu / 1.84 job though
tullom
previously approved these changes
Oct 29, 2025
🧟 zombie process, just in time for halloween 🎃 |
Only temperatures are swapped. Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
kurtjd
approved these changes
Oct 30, 2025
tullom
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.