Fix config register byte order#19
Merged
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom Jun 19, 2025
Merged
Conversation
felipebalbi
approved these changes
Jun 15, 2025
jerrysxie
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver currently assumes byte 1 of the config register is the LSB and byte 2 is the MSB. This PR changes it to the correct order (byte 1 is MSB, byte 2 is LSB).
This was discovered after writing
Config::default()to a TMP108 device. The device was not returning fresh temperature samples during periodic polling. Likely the device was in shutdown mode since the current default value written would be0x1022which would cause M1 and M0 bits to be set to0b00(shutdown mode).This fix thus changes the default value to
0x2210which makes the device operate as expected.