Implement FileClient2 progress callbacks #353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pycyphal/application/file.py
Outdated
| path: str, | ||
| offset: int = 0, | ||
| size: typing.Optional[int] = None, | ||
| progress: typing.Optional[typing.Callable[[int, int], None]] = None, |
There was a problem hiding this comment.
The code you're editing was written a long time ago. Now the recommended syntax is int | None instead of Optional[int], Callable[[int, int], None] | None, memoryview | bytes, etc. I'm not saying you need to update existing code but if you're editing something that uses old-style annotations it would be nice to replace them.
|
Thank you. I moved your changes to #354 and I am going to merge it next. |
pavel-kirienko
added a commit
that referenced
this pull request
May 21, 2025
Supersedes #353 --------- Co-authored-by: chemicstry <chemicstry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will leave this as draft until OpenCyphal/yakut#119 is finished, in case any additional changes are needed