Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Nunavut v2 #277

Closed
pavel-kirienko opened this issue Mar 7, 2023 · 2 comments · Fixed by #318
Closed

Migrate to Nunavut v2 #277

pavel-kirienko opened this issue Mar 7, 2023 · 2 comments · Fixed by #318
Assignees
@Willmac16
Labels
class-maintenance domain-core severity-major

Comments

@pavel-kirienko
Copy link
Member

No description provided.

@pavel-kirienko pavel-kirienko mentioned this issue May 10, 2023
Closed
@pavel-kirienko pavel-kirienko mentioned this issue May 21, 2023
Merged
3 tasks
pavel-kirienko added a commit to OpenCyphal/nunavut that referenced this issue Aug 18, 2023
@pavel-kirienko
Add Python codegen (#306)
b2a82de 
This changeset also drops support for Python 3.6.

Fixes OpenCyphal/pycyphal#110
Required for OpenCyphal/pycyphal#277
Supersedes #234
@Willmac16
Copy link
Contributor

Is there a list of remaining tasks to move to Nunavut v2?

I would be happy to help if I can, as my build system would be greatly simplified without two different versions of Nunavut to wrangle.

@pavel-kirienko
Copy link
Member Author

List of tasks to move to Nunavut v2:

Remove the DSDL templates completely and instead invoke the default Python generator available in Nunavut v2. These directories need to go: pycyphal/dsdl/_templates, pycyphal/dsdl/_serialized_representation. _builtin_form.py, _composite_object.py are not needed either because the respective functionality has been moved into the Nunavut-generated support module.

Upgrade _compiler.py to invoke the new Nunavut API correctly.

Remove all DSDL-related tests affected by the removal of the modules mentioned above. They have already been migrated to Nunavut.

@pavel-kirienko pavel-kirienko assigned Willmac16 and unassigned songmeo Dec 23, 2023
@Willmac16 Willmac16 mentioned this issue Jan 3, 2024
Merged
@pavel-kirienko pavel-kirienko linked a pull request Jan 8, 2024 that will close this issue
Migrate to Nunavut v2 #318
Merged
pavel-kirienko added a commit that referenced this issue Jan 8, 2024
@Willmac16 @emrainey @pavel-kirienko
Migrate to Nunavut v2 (#318)
d02f84e 
Closes #277 

Co-authored-by: Erik Rainey <erik.rainey@gmail.com>
Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Willmac16 Willmac16

Labels
class-maintenance domain-core severity-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to Nunavut v2 Willmac16/pycyphal
3 participants
@pavel-kirienko @Willmac16 @songmeo