Issue #94 and progress on Issue #91 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thirtytwobits
force-pushed
the
issue/91_2
branch
4 times, most recently
from
9cba598
to
f75633c
Compare
Major refactor of language context to drive filter options from configuration. The ability to modify things like stropping and encoding were fundamentally broken before this change. This work was done in support of adding named types as a concept to languages. This will allow generation of serialization code that is more configurable and will avoid fixing decisions like the use of size_t into templates instead moving these decisions into user-overridable configuration.
thirtytwobits
force-pushed
the
issue/91_2
branch
from
f75633c
to
dce6b3d
Compare
pavel-kirienko
requested changes
Dec 6, 2019
Could you share the link, please? |
|
pavel-kirienko
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor of language context to derive filter options from
configuration. The ability to disable or modify things like stropping and
encoding were fundamentally broken before this change.
This work was done in support of adding named types as a concept to
languages. This will allow generation of serialization code that is more
configurable and will avoid fixing decisions like the use of size_t into
templates instead moving these decisions into user-overridable
configuration.
Also moved a bunch of stuff into tox.ini after reading a screed by the pytest maintainers about how broken it is to put stuff in Setup.cfg. Even so, I'm learning this amounts to a re-arranging of deck chairs given PEP-518. sigh. It seems, perhaps, someday Python will get project configuration right but that day isn't here just yet.