This repository was archived by the owner on Nov 15, 2021. It is now read-only.
Merged
Conversation
added 6 commits
January 11, 2016 14:55
Member
|
I don't understad the purpose of these tests that .dll, a process cannot be a .dll can it? |
Contributor
Author
|
It is to confirm match & mismatch of start and of end of process-name, simple string filter matching test. But yes, I could use never matching ".dll" extension in filter instead giving it to process name, that would be the same logic. BTW, in later commits, I added more and removed duplicate tests. |
Contributor
Author
|
However, It is true that using .dll extension could be confusing. .dll extension removed or moved from process name to filter: 2c7ba27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore test cases