This repository was archived by the owner on Nov 15, 2021. It is now read-only.
[WIP] Prerequisites for Mono build#265
Merged
sawilde merged 5 commits intoOpenCover:masterfrom Feb 21, 2015
Merged
Conversation
molnargab
changed the title
molnargab
changed the title
Member
|
@molnargab as it says [wip], are you intending to add more to it before it's fully ready for a merge? |
Contributor
Author
|
I think I can't add anything else for now. WIP is meant to indicate that the build is not yet successful. |
Member
|
Okay - I am just wondering if we need it on the main repo yet if the work is not yet ready - it builds so is safe to take according to the tests, but I didn't want to take stuff too early as you may have been using the PR as a build test against the build servers; a legitimate thing to do IMO. |
sawilde
added a commit
that referenced
this pull request
Feb 21, 2015
[WIP] Prerequisites for Mono build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#228: This fixes a couple of file reference issues, e.g. upper cased file names or hard-coded path separators.
Though Mono provides a flag to enable backslash as a separator, I think it's more robust to rely on the runtime.
So far the build isn't successful, there seem to be some issue with resolving Gendarme.Rules.Maintanability.dll on Mono 3.12, though I was able to build it with MonoDevelop for Mono 3.2.8 (needed to upgrade to 3.12 in order to fix some failed tests with XmlSerialization).
I think it's safe to merge these changes already, as they're transparent for Windows builds.