Random access violations with VS2015 compiler and OpenCover 4.6.166 / 4.5.3723

[Sam13]

I upgraded recently from VS2010 .NET 4.0 / OpenCover 4.5.3522 to
VS2015 .NET 4.0 (uses .NET 4.5 compiler to generate .NET 4.0) / OpenCover 4.5.3723 / 4.6.166

When running my unit tests compiled with VS2010 and OpenCover 4.5.3522 they work fine.
When running my unit tests compiled with VS2015 without OpenCover they work fine.

When running with OC 4.6.166 or 4.5.3723 they crash randomly.
I cannot use a version < 4.5.3723 because of #319 .

Mostly there is an AccessVioloationException

Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
at System.CannotUnloadAppDomainException.VisitedCritical(Int32 )
at System.CannotUnloadAppDomainException.SafeVisited(Int32 )
(anonymized)

or sometimes an ArgumentOutOfRangeException:

Unhandled Exception: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
[asyncexec] Parameter name: startIndex
[asyncexec]    at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
[asyncexec]    at System.BitConverter.ToUInt32(Byte[] value, Int32 startIndex)
[asyncexec]    at OpenCover.Framework.Persistance.BasePersistance.SaveVisitData(Byte[] data) in c:\projects\opencover\main\OpenCover.Framework\Persistance\BasePersistance.cs:line 494
[asyncexec]    at OpenCover.Framework.Manager.ProfilerManager.<>c__DisplayClass7.<SaveVisitData>b__6(Object state) in c:\projects\opencover\main\OpenCover.Framework\Manager\ProfilerManager.cs:line 157
[asyncexec]    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
[asyncexec]    at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
[asyncexec]    at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
[asyncexec]    at System.Threading.ThreadPoolWorkQueue.Dispatch()

[sawilde]

looks like it is related to this pull request #330 - do you have a code sample so I can investigate the latter issue further?

[Sam13]

Unfortunately I can provide a sample to reproduce because the crashes occur more or less randomly.
I also noticed that version 4.5.3723 is not running smoothly, at least in my environment...

I've built the fix version from #330 myself and will run it in my environment to see if this fixes the crashes...

[Sam13]

urasandesu@d1f07d4 does not fix my problem, still access violations.

I can offer to run an instrumented build on my environment which collects hopefully helpful informations about the problem...

[sawilde]

@Sam13 - thanks for the offer but I tend to tweak the instrumentation based on the issue - otherwise it's too hard to wade through all the data - hence why a reproducible sample is much easier

[Sam13]

@sawilde Did you try to run the OpenCover over something compiled with VS2015?

I tried again to find some repeatable behavior but without success. I tried to isolate a failing test assembly (normally run OpenCover over nunit-console with 33 different assemblies). When I run only over an assembly that might have caused the crash it did not crash anymore...

The only thing I got might not be very helpful

Application: nunit-agent-x86.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.AccessViolationException
Stack:
   at System.AppDomain.SetupDomain(Boolean, System.String, System.String, System.String[], System.String[])

Since I'm not very familiar with unmanaged code can you give me some advice how to lookup for something that might help you?

[bunnu]

Same issue here:

Ausnahmefehler: System.ArgumentOutOfRangeException: Der Index lag auáerhalb des Bereichs. Er muss nicht negativ und kleiner als die Auflistung sein.
Parametername: startIndex
   bei System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
   bei System.BitConverter.ToUInt32(Byte[] value, Int32 startIndex)
   bei OpenCover.Framework.Persistance.BasePersistance.SaveVisitData(Byte[] data) in c:\projects\opencover\main\OpenCover.Framework\Persistance\BasePersistance.cs:Zeile 494.
   bei OpenCover.Framework.Manager.ProfilerManager.<>c__DisplayClass7.<SaveVisitData>b__6(Object state) in c:\projects\opencover\main\OpenCover.Framework\Manager\ProfilerManager.cs:Zeile 157.
   bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   bei System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   bei System.Threading.ThreadPoolWorkQueue.Dispatch()

I'm using VS 2015 / Microsoft Build Tools 2015 and nunit. The problem appears randomly.

[Sam13]

Version 15c47b8 still crashes

Application: nunit-agent-x86.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.AccessViolationException
Stack:
at System.AppDomain.SetupDomain(Boolean, System.String, System.String, System.String[], System.String[])

[sawilde]

It seems odd that this is happening in System.AppDomain.SetupDomain, what filters are you using? I tend to ignore System as it is not user code.

A repeatable example would be really useful right now.

[Sam13]

I set the filter like that:

-filter:"+[AppAssembly1]*  +[AppAssembly2]*  -[AppAssembly2]AppNamespace2.UserControl* -[AppAssembly2]AppNamespace2.Properties.* +[AppAssembly3]* +[AppAssembly4]* -[log4net*]* -[*nunit*]* -[msvcm*]* -[Rhino.Mocks*]* -[NLog*]* -[*UnitTest]*" -excludebyattribute:System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute

I totally agree a sample would be nice, but I can't provide one.
As @bunnu stated the exceptions appear to be randomly, I have about 35 unit test assemblies with total over 10000 unit tests. Since I'm not familiar with unmanaged code / access violation debugging I did not even manage to determine the name of the failing tests so far :-(

[bunnu]

Unfortunately I don't have an repeatable example. The exception occurs randomly at different tests. Sometimes the error appears 1-2 times a day. Sometimes it takes a few days until it happens again.
I'll try to setup a simple unit-Test Solution and run it endless until the exception hopefully occurs. If so, I will provide you the code.

[sawilde]

@Sam13 - It's not something I have seen myself so I don't know if it is OpenCover causing NUnit to crash or NUnit just crashing; especially in the case of the crash in SetupDomain as OpenCover would not touch that method as it is not in the filters and you probably don't have a PDB for it either. Do you see an entry in the XML file for that method?

@bunnu - Have you tried the latest build? https://ci.appveyor.com/project/sawilde/opencover/build/4.6.177/artifacts