Merged
Conversation
quartje
force-pushed
the
feature/build-and-publish-test-container
branch
2 times, most recently
from
85a1e21 to
436b3b7
Compare
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
from
1610a5e to
29c6df4
Compare
MKodde
changed the title
The docker image needs a php82 container as base. The tag-release Github action is set to use the Stepup-Deploy branch with php82 support
MKodde
reviewed
Dec 18, 2023
docker/Dockerfile.prod
Outdated
| @@ -7,7 +7,6 @@ RUN tar -xvjf /tmp/*.tar.bz2 -C /var/www/html/ && \ | |||
| COPY config/packages/parameters.yaml.dist config/packages/parameters.yaml | |||
| COPY config/packages/prod/monolog.yaml.docker config/packages/prod/monolog.yaml | |||
| COPY .env.docker .env | |||
Member
There was a problem hiding this comment.
This can be removed right? As I see it, the env var is not evaluated via this file any longer. But should be placed in the ENV by docker compose or another means.
quartje
force-pushed
the
feature/build-and-publish-test-container
branch
from
fed7557 to
7ddd66f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add an action to build a container for testing purposes.