Feat: Allow Dependency Injection from Symfony into Corto#1874
Merged
johanib merged 1 commit intoupgrade-84from Nov 5, 2025
Merged
Feat: Allow Dependency Injection from Symfony into Corto#1874johanib merged 1 commit intoupgrade-84from
johanib merged 1 commit intoupgrade-84from
Conversation
5 tasks
johanib
added a commit
that referenced
this pull request
Oct 8, 2025
Prior to this change, it was not possible to inject dependencies into Corto in a modern way. Corto pulled all dependencies from the Symfony service container itself. This caused issues, because it is no longer possible to pull twig from the service container in Symfony 6.4. This change introduces a DiContainerRuntime, which can be used to inject dependencies into Corto. This was not possible using the DiContainer, because the DiContainer is constructed during bundle bootstrapping, where DI is not available. It is not possible to move it from there, as it is required by various constructions in the bootstapping process. The DiContainerRuntime is injected into Corto after bootstrapping, but before the request is handled. #1874
johanib
force-pushed
the
feature/twig_di
branch
from
74fa5f1 to
86ed9ce
Compare
johanib
changed the title
MKodde
requested changes
Oct 29, 2025
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
Interesting PR! I see you deprecated the current way of working with the 'old' DiContainer. And you hint that any new service should be added to the new runtime version. Would it not be more elegant to move them all right now? That way, you can actually remove the old version in the next version. Now you might run into unforeseen issues and end up keeping the old and the new for a long time.
github-project-automation
bot
moved this from In Progress
to Backlog
in PHP development
Contributor
Author
After discussion:
I agree it would be nice to move most services over. |
johanib
added a commit
that referenced
this pull request
Nov 5, 2025
Prior to this change, it was not possible to inject dependencies into Corto in a modern way. Corto pulled all dependencies from the Symfony service container itself. This caused issues, because it is no longer possible to pull twig from the service container in Symfony 6.4. This change introduces a DiContainerRuntime, which can be used to inject dependencies into Corto. This was not possible using the DiContainer, because the DiContainer is constructed during bundle bootstrapping, where DI is not available. It is not possible to move it from there, as it is required by various constructions in the bootstapping process. The DiContainerRuntime is injected into Corto after bootstrapping, but before the request is handled. #1874
johanib
force-pushed
the
feature/twig_di
branch
from
86ed9ce to
ee7ba26
Compare
Contributor
Author
Done. |
Prior to this change, it was not possible to inject dependencies into Corto in a modern way. Corto pulled all dependencies from the Symfony service container itself. This caused issues, because it is no longer possible to pull twig from the service container in Symfony 6.4. This change introduces a DiContainerRuntime, which can be used to inject dependencies into Corto. This was not possible using the DiContainer, because the DiContainer is constructed during bundle bootstrapping, where DI is not available. It is not possible to move it from there, as it is required by various constructions in the bootstapping process. The DiContainerRuntime is injected into Corto after bootstrapping, but before the request is handled. #1874
johanib
force-pushed
the
feature/twig_di
branch
from
ee7ba26 to
5dc1e99
Compare
johanib
added a commit
that referenced
this pull request
Feb 9, 2026
Prior to this change, it was not possible to inject dependencies into Corto in a modern way. Corto pulled all dependencies from the Symfony service container itself. This caused issues, because it is no longer possible to pull twig from the service container in Symfony 6.4. This change introduces a DiContainerRuntime, which can be used to inject dependencies into Corto. This was not possible using the DiContainer, because the DiContainer is constructed during bundle bootstrapping, where DI is not available. It is not possible to move it from there, as it is required by various constructions in the bootstapping process. The DiContainerRuntime is injected into Corto after bootstrapping, but before the request is handled. #1874
johanib
added a commit
that referenced
this pull request
Feb 10, 2026
Prior to this change, it was not possible to inject dependencies into Corto in a modern way. Corto pulled all dependencies from the Symfony service container itself. This caused issues, because it is no longer possible to pull twig from the service container in Symfony 6.4. This change introduces a DiContainerRuntime, which can be used to inject dependencies into Corto. This was not possible using the DiContainer, because the DiContainer is constructed during bundle bootstrapping, where DI is not available. It is not possible to move it from there, as it is required by various constructions in the bootstapping process. The DiContainerRuntime is injected into Corto after bootstrapping, but before the request is handled. #1874
johanib
added a commit
that referenced
this pull request
Feb 10, 2026
Prior to this change, it was not possible to inject dependencies into Corto in a modern way. Corto pulled all dependencies from the Symfony service container itself. This caused issues, because it is no longer possible to pull twig from the service container in Symfony 6.4. This change introduces a DiContainerRuntime, which can be used to inject dependencies into Corto. This was not possible using the DiContainer, because the DiContainer is constructed during bundle bootstrapping, where DI is not available. It is not possible to move it from there, as it is required by various constructions in the bootstapping process. The DiContainerRuntime is injected into Corto after bootstrapping, but before the request is handled. #1874
johanib
added a commit
that referenced
this pull request
Feb 25, 2026
Prior to this change, it was not possible to inject dependencies into Corto in a modern way. Corto pulled all dependencies from the Symfony service container itself. This caused issues, because it is no longer possible to pull twig from the service container in Symfony 6.4. This change introduces a DiContainerRuntime, which can be used to inject dependencies into Corto. This was not possible using the DiContainer, because the DiContainer is constructed during bundle bootstrapping, where DI is not available. It is not possible to move it from there, as it is required by various constructions in the bootstapping process. The DiContainerRuntime is injected into Corto after bootstrapping, but before the request is handled. #1874
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, it was not possible to inject dependencies into Corto in a modern way. Corto pulled all dependencies from the Symfony service container itself.
This caused issues, because it is no longer possible to pull twig from the service container in Symfony 6.4.
This change introduces a DiContainerRuntime, which can be used to inject dependencies into Corto. This was not possible using the DiContainer, because the DiContainer is constructed during bundle bootstrapping, where DI is not available. It is not possible to move it from there, as it is required by various constructions in the bootstapping process.
The DiContainerRuntime is injected into Corto after bootstrapping, but before the request is handled.
#1874